[webkit-reviews] review denied: [Bug 95456] Web Inspector: render box model elements and grid on inspector overlay : [Attachment 161484] Patch

[bugzilla-daemon at webkit.org]

Vsevolod Vlasov <vsevik at chromium.org> has denied Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 95456: Web Inspector: render box model elements and grid on inspector
overlay
https://bugs.webkit.org/show_bug.cgi?id=95456

Attachment 161484: Patch
https://bugs.webkit.org/attachment.cgi?id=161484&action=review

------- Additional Comments from Vsevolod Vlasov <vsevik at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=161484&action=review


> Source/WebCore/inspector/InspectorOverlay.cpp:48
> +#include "RenderView.h"

Not needed ?

> Source/WebCore/inspector/InspectorOverlay.cpp:393
>  {

Maybe 
if (m_pausedInDebuggerMessage.isEmpty())
    return
?

> Source/WebCore/inspector/InspectorOverlay.cpp:425
> +#if OS(WINDOWS)

Move this checks in InspectorOverlayPage.html ?

> Source/WebCore/inspector/InspectorOverlay.cpp:426
> +overlaySettings->setDefaultFontSize(12);

indent

> Source/WebCore/inspector/InspectorOverlay.h:34
> +#include "InspectorValues.h"

is that needed?

> Source/WebCore/inspector/InspectorOverlayPage.html:84
> +function takeLast(array)

array.pop()