[webkit-reviews] review requested: [Bug 72811] [Gtk] No accessible caret-moved events found in certain content : [Attachment 161630] proposed fix - part 3 (addressed feedback from review)

[bugzilla-daemon at webkit.org]

Joanmarie Diggs (irc: joanie) <jdiggs at igalia.com> has asked  for review:
Bug 72811: [Gtk] No accessible caret-moved events found in certain content
https://bugs.webkit.org/show_bug.cgi?id=72811

Attachment 161630: proposed fix - part 3 (addressed feedback from review)
https://bugs.webkit.org/attachment.cgi?id=161630&action=review

------- Additional Comments from Joanmarie Diggs (irc: joanie)
<jdiggs at igalia.com>
(In reply to comment #40)
> (From update of attachment 160550 [details])
> View in context:
https://bugs.webkit.org/attachment.cgi?id=160550&action=review
> 
> looks ok otherwise
> 
> > Source/WebCore/accessibility/gtk/AccessibilityObjectAtk.cpp:82
> > +	 // ignores the paragraph or div and includes the block. We want the
opposite.
> 
> it might be worth noting why GTK wants to do the opposite (since there's no
link back to which bug this is fixing)

Done. Thanks for the review!

r?ing and cq?ing. But note that this patch expects/depends upon the "Part 2"
patch, so I fully expect the EWS to spit up on this.