[webkit-reviews] review denied: [Bug 95187] Web Inspector: Add ability to replay XHR in network panel. : [Attachment 161487] Patch

[bugzilla-daemon at webkit.org]

Vsevolod Vlasov <vsevik at chromium.org> has denied Pavel Chadnov
<chadnov at google.com>'s request for review:
Bug 95187: Web Inspector: Add ability to replay XHR in network panel.
https://bugs.webkit.org/show_bug.cgi?id=95187

Attachment 161487: Patch
https://bugs.webkit.org/attachment.cgi?id=161487&action=review

------- Additional Comments from Vsevolod Vlasov <vsevik at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=161487&action=review


> Source/WebCore/inspector/InspectorResourceAgent.cpp:212
> +	   OwnPtr<CrossThreadHTTPHeaderMapData> headerMapData =
headers.copyData();

Please remove

> Source/WebCore/inspector/InspectorResourceAgent.cpp:614
> +	   xhr->setRequestHeader(it->first, it->second, code);	 
xhr->sendFromInspector(xhrData->m_formData, code);

New line

> Source/WebCore/inspector/NetworkResourcesData.cpp:276
> +void NetworkResourcesData::setXHRReplayData(const String& requestId,
PassRefPtr<XHRReplayData> XHRData)

zhrData

> Source/WebCore/inspector/NetworkResourcesData.h:51
> +    String m_method;

Please make fields private an add getters.

> Source/WebCore/inspector/NetworkResourcesData.h:108
> +	   void setXHRReplayData(PassRefPtr<XHRReplayData> XHRData) {
m_xhrReplayData = XHRData;};

space between ; and }

> Source/WebCore/loader/DocumentThreadableLoader.cpp:404
> +    if (m_actualRequest)

Please surround with #if ENABLE(INSPECTOR)