[webkit-reviews] review granted: [Bug 72811] [Gtk] No accessible caret-moved events found in certain content : [Attachment 160550] proposed fix - part 3 (includes new test)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 30 21:33:10 PDT 2012


chris fleizach <cfleizach at apple.com> has granted Joanmarie Diggs
<jdiggs at igalia.com>'s request for review:
Bug 72811: [Gtk] No accessible caret-moved events found in certain content
https://bugs.webkit.org/show_bug.cgi?id=72811

Attachment 160550: proposed fix - part 3 (includes new test)
https://bugs.webkit.org/attachment.cgi?id=160550&action=review

------- Additional Comments from chris fleizach <cfleizach at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=160550&action=review


looks ok otherwise

> Source/WebCore/accessibility/gtk/AccessibilityObjectAtk.cpp:82
> +    // ignores the paragraph or div and includes the block. We want the
opposite.

it might be worth noting why GTK wants to do the opposite (since there's no
link back to which bug this is fixing)


More information about the webkit-reviews mailing list