[webkit-reviews] review granted: [Bug 95518] Loading a worker script should not be O(n^2) : [Attachment 161598] Patch

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has granted Adam Barth
<abarth at webkit.org>'s request for review:
Bug 95518: Loading a worker script should not be O(n^2)
https://bugs.webkit.org/show_bug.cgi?id=95518

Attachment 161598: Patch
https://bugs.webkit.org/attachment.cgi?id=161598&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
The patch looks good.

JavaScriptCore has an optimized class for joining a list of WTF::String with an
optional delimiter: JSStringJoiner. JSStringJoiner is very specific to JSC
(allocation with tryXXX and the number of strings must be known in advance).

If the pattern of this patch appears in sections where performance is critical,
we should write a StringJoiner for WTF.