[webkit-reviews] review denied: [Bug 94858] AX: Regression (r126369) - toggle buttons no longer return accessible titles : [Attachment 161275] Fixes the bug

[bugzilla-daemon at webkit.org]

chris fleizach <cfleizach at apple.com> has denied Alejandro Piñeiro
<apinheiro at igalia.com>'s request for review:
Bug 94858: AX: Regression (r126369) - toggle buttons no longer return
accessible titles
https://bugs.webkit.org/show_bug.cgi?id=94858

Attachment 161275: Fixes the bug
https://bugs.webkit.org/attachment.cgi?id=161275&action=review

------- Additional Comments from chris fleizach <cfleizach at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=161275&action=review


> Source/WebCore/accessibility/AccessibilityObject.h:380
> +    bool isButton() const { return roleValue() == ButtonRole ||
PopUpButtonRole || ToggleButtonRole; }

this logic is wrong. This will make isButton always return true.
i think we want roleValue() == Button || roleValue() == Popup ...
since it will be a bit longer might as well put it in the .cpp file and cache
roleValue

AccessibilityRole role = roleValue()
return role == Button || role == Popup ...