[webkit-reviews] review granted: [Bug 95207] CSS Parser should directly parse 8 bit source strings : [Attachment 161552] Patch with test changed to a reference test

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Michael Saboff
<msaboff at apple.com>'s request for review:
Bug 95207: CSS Parser should directly parse 8 bit source strings
https://bugs.webkit.org/show_bug.cgi?id=95207

Attachment 161552: Patch with test changed to a reference test
https://bugs.webkit.org/attachment.cgi?id=161552&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=161552&action=review


r=me

> Source/WebCore/css/CSSParser.cpp:8603
> +UChar*&
> +CSSParser::currentCharacter16()

Should be on the same line.

> Source/WebCore/css/CSSParser.cpp:8891
> +inline void CSSParser::parseURI(CSSParserString& string)

This could be a function template, since the logic in the 8 vs 16 bit cases is
equal.