[webkit-reviews] review denied: [Bug 95400] [Chromium-Android] Skip compositing/webgl and platform/chromium/virtual/threaded/compositing/webgl tests : [Attachment 161357] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 30 14:58:08 PDT 2012


Dirk Pranke <dpranke at chromium.org> has denied Xianzhu Wang
<wangxianzhu at chromium.org>'s request for review:
Bug 95400: [Chromium-Android] Skip compositing/webgl and
platform/chromium/virtual/threaded/compositing/webgl tests
https://bugs.webkit.org/show_bug.cgi?id=95400

Attachment 161357: Patch
https://bugs.webkit.org/attachment.cgi?id=161357&action=review

------- Additional Comments from Dirk Pranke <dpranke at chromium.org>
why don't you just include the directories below line 258?

Also, I think that ever since I implemented support for cascading expectations,
skipped directory names will skip all of the tests in the directory even if
there are individual expectations for a test in earlier files. So, I don't
think you need to call _real_tests() at all, you can just return a list of
directories.

We should test this, and if what I just wrote is wrong, fix the bugs and make
it right :).


More information about the webkit-reviews mailing list