[webkit-reviews] review denied: [Bug 95303] [WK2] Text direction API for WK2 : [Attachment 161530] patch v3

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied Mikhail Pozdnyakov
<mikhail.pozdnyakov at intel.com>'s request for review:
Bug 95303: [WK2] Text direction API for WK2
https://bugs.webkit.org/show_bug.cgi?id=95303

Attachment 161530: patch v3
https://bugs.webkit.org/attachment.cgi?id=161530&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=161530&action=review


> Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePage.h:94
> -typedef void (*WKBundlePageDidReceiveTitleForFrameCallback)(WKBundlePageRef
page, WKStringRef title, WKBundleFrameRef frame, WKTypeRef* userData, const
void *clientInfo);
> +typedef void (*WKBundlePageDidReceiveTitleForFrameCallback)(WKBundlePageRef
page, WKStringRef title, WKTextDirection titleDirection, WKBundleFrameRef
frame, WKTypeRef* userData, const void *clientInfo);

Same problem here as with the last patch, albeit in a different place. Changing
the arguments here breaks the API. That’s why this header is in a directory
named API.