[webkit-reviews] review requested: [Bug 95482] JSC: Render unto #ifdef's that which belong to them : [Attachment 161548] Fix HAVE(COMPUTED_GOTO) && !ENABLE(COMPUTED_GOTO_CLASSIC_INTERPRETER) case.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 30 13:49:08 PDT 2012


Mark Lam <mark.lam at apple.com> has asked  for review:
Bug 95482: JSC: Render unto #ifdef's that which belong to them
https://bugs.webkit.org/show_bug.cgi?id=95482

Attachment 161548: Fix HAVE(COMPUTED_GOTO) &&
!ENABLE(COMPUTED_GOTO_CLASSIC_INTERPRETER) case.
https://bugs.webkit.org/attachment.cgi?id=161548&action=review

------- Additional Comments from Mark Lam <mark.lam at apple.com>
I missed the case where someone may want to build the classic interpreter
without compute gotos even when HAVE(COMPUTED_GOTO) is defined.  Anyway, this
is now fixed by not enabling ENABLE(COMPUTED_GOTO_OPCODES) when
!ENABLE(COMPUTED_GOTO_CLASSIC_INTERPRETER).


More information about the webkit-reviews mailing list