[webkit-reviews] review granted: [Bug 95232] [Mac] Add testRunner.dumpWebNotificationCallbacks() to DRT : [Attachment 161308] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 30 11:35:45 PDT 2012


Alexey Proskuryakov <ap at webkit.org> has granted Jon Lee <jonlee at apple.com>'s
request for review:
Bug 95232: [Mac] Add testRunner.dumpWebNotificationCallbacks() to DRT
https://bugs.webkit.org/show_bug.cgi?id=95232

Attachment 161308: Patch
https://bugs.webkit.org/attachment.cgi?id=161308&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=161308&action=review


> Tools/DumpRenderTree/mac/UIDelegate.mm:294
> +    printf("REQUESTED WEB NOTIFICATION PERMISSION FOR %s\n", [[origin
stringValue] UTF8String]);

Should this be guarded by gTestRunner->dumpWebNotificationCallbacks?


More information about the webkit-reviews mailing list