[webkit-reviews] review denied: [Bug 90079] [CSS Regions] It should be possible to specify ::BEFORE/AFTER as regions : [Attachment 161429] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 30 10:50:26 PDT 2012


Dave Hyatt <hyatt at apple.com> has denied Andrei Bucur <abucur at adobe.com>'s
request for review:
Bug 90079: [CSS Regions] It should be possible to specify ::BEFORE/AFTER as
regions
https://bugs.webkit.org/show_bug.cgi?id=90079

Attachment 161429: Patch
https://bugs.webkit.org/attachment.cgi?id=161429&action=review

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=161429&action=review


Just one question about this one.

> Source/WebCore/rendering/RenderRegion.h:50
> +    // Regions can't have any children.
> +    virtual bool isChildAllowed(RenderObject*, RenderStyle*) const { return
false; }

This is weird to me. Eventually we want to turn RenderRegions into RenderBlocks
so that they can have ::before and ::after children. In other words, we do want
to support children on RenderRegions eventually, so why do we turn that off?


More information about the webkit-reviews mailing list