[webkit-reviews] review granted: [Bug 95198] MediaStream API: Introduce MediaConstraints : [Attachment 161505] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Aug 30 10:34:49 PDT 2012
Adam Barth <abarth at webkit.org> has granted Tommy Widenflycht
<tommyw at google.com>'s request for review:
Bug 95198: MediaStream API: Introduce MediaConstraints
https://bugs.webkit.org/show_bug.cgi?id=95198
Attachment 161505: Patch
https://bugs.webkit.org/attachment.cgi?id=161505&action=review
------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=161505&action=review
Ok. If you think this pattern is better in some cases, we can give it a try.
Thanks for being patient with me. :)
> Source/WebCore/bindings/v8/Dictionary.cpp:497
> +bool Dictionary::getOwnPropertyNames(WTF::Vector<String>& names) const
Technically this doesn't need a WTF either. The WTF headers tend to have
"using" statements that import these names.
More information about the webkit-reviews
mailing list