[webkit-reviews] review denied: [Bug 95303] [WK2] Text direction API for WK2 : [Attachment 161449] patch v2
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Aug 30 09:57:29 PDT 2012
Alexey Proskuryakov <ap at webkit.org> has denied Mikhail Pozdnyakov
<mikhail.pozdnyakov at intel.com>'s request for review:
Bug 95303: [WK2] Text direction API for WK2
https://bugs.webkit.org/show_bug.cgi?id=95303
Attachment 161449: patch v2
https://bugs.webkit.org/attachment.cgi?id=161449&action=review
------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=161449&action=review
> Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePage.h:94
> -typedef void (*WKBundlePageDidReceiveTitleForFrameCallback)(WKBundlePageRef
page, WKStringRef title, WKBundleFrameRef frame, WKTypeRef* userData, const
void *clientInfo);
> +typedef void (*WKBundlePageDidReceiveTitleForFrameCallback)(WKBundlePageRef
page, WKStringRef title, WKTextDirection titleDirection, WKBundleFrameRef
frame, WKTypeRef* userData, const void *clientInfo);
If you change existing API, WebKit nightlies will no longer work with Safari,
which is unacceptable.
More information about the webkit-reviews
mailing list