[webkit-reviews] review granted: [Bug 94810] Vector::shrinkToFit should use realloc when canMoveWithMemcpy is true : [Attachment 161271] Again

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 30 09:44:21 PDT 2012


Benjamin Poulain <benjamin at webkit.org> has granted Yong Li <yoli at rim.com>'s
request for review:
Bug 94810: Vector::shrinkToFit should use realloc when canMoveWithMemcpy is
true
https://bugs.webkit.org/show_bug.cgi?id=94810

Attachment 161271: Again
https://bugs.webkit.org/attachment.cgi?id=161271&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=161271&action=review


The patch looks correct. Just make sure there is no problem with GTK when you
land it.

> Source/WTF/ChangeLog:8
> +	   Only tested on BlackBerry. So it is wrapped with
PLATFORM(BLACKBERRY) at the mean time.

"at the mean time" -> in the meantime.


More information about the webkit-reviews mailing list