[webkit-reviews] review granted: [Bug 91214] [EFL][WK2] Add WebMemorySampler feature. : [Attachment 161479] Patch

[bugzilla-daemon at webkit.org]

Kenneth Rohde Christiansen <kenneth at webkit.org> has granted JungJik Lee
<jungjik.lee at samsung.com>'s request for review:
Bug 91214: [EFL][WK2] Add WebMemorySampler feature.
https://bugs.webkit.org/show_bug.cgi?id=91214

Attachment 161479: Patch
https://bugs.webkit.org/attachment.cgi?id=161479&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=161479&action=review


> Source/WebKit2/Shared/linux/WebMemorySamplerLinux.cpp:150
> +    FastMallocStatistics fastMallocStatistics = WTF::fastMallocStatistics();

> +    size_t fastMallocBytesInUse = fastMallocStatistics.committedVMBytes -
fastMallocStatistics.freeListBytes;
> +    size_t fastMallocBytesCommitted = fastMallocStatistics.committedVMBytes;

> +    totalBytesInUse += fastMallocBytesInUse;
> +    totalBytesCommitted += fastMallocBytesCommitted;

i like the fast malloc to use an ifdef as well

> Source/WebKit2/UIProcess/API/efl/ewk_context.cpp:91
> +	   static const char environmentVariable[] = "MEMORY_SAMPLER";

Wouldn't SAMPLE_MEMORY not be better? What does other ports use?