[webkit-reviews] review denied: [Bug 95443] Web Inspector: [WebGL] Save gl.getError() status before taking a WebGL state snapshot and restore it afterwards : [Attachment 161451] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Aug 30 08:06:21 PDT 2012
Vsevolod Vlasov <vsevik at chromium.org> has denied Andrey Adaikin
<aandrey at chromium.org>'s request for review:
Bug 95443: Web Inspector: [WebGL] Save gl.getError() status before taking a
WebGL state snapshot and restore it afterwards
https://bugs.webkit.org/show_bug.cgi?id=95443
Attachment 161451: Patch
https://bugs.webkit.org/attachment.cgi?id=161451&action=review
------- Additional Comments from Vsevolod Vlasov <vsevik at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=161451&action=review
> Source/WebCore/inspector/InjectedScriptWebGLModuleSource.js:43
> + TypedArrayClasses: (function(typeNames) {
Why did this change?
> Source/WebCore/inspector/InjectedScriptWebGLModuleSource.js:1529
> + var wrapFunctions = WebGLRenderingContextResource._WrapFunctions;
Can we make wrapFunctions changes in a separate patch?
More information about the webkit-reviews
mailing list