[webkit-reviews] review denied: [Bug 95381] [BlackBerry] Modifying how IP domains are handled in Cookies : [Attachment 161320] Patch

[bugzilla-daemon at webkit.org]

Rob Buis <rwlbuis at gmail.com> has denied otcheung at rim.com's request for review:
Bug 95381: [BlackBerry] Modifying how IP domains are handled in Cookies
https://bugs.webkit.org/show_bug.cgi?id=95381

Attachment 161320: Patch
https://bugs.webkit.org/attachment.cgi?id=161320&action=review

------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=161320&action=review


Looks good, still cleanup to do.

> Source/WebCore/platform/blackberry/CookieManager.h:117
> +    CookieMap* findOrCreateCookieMap(CookieMap* protocolMap, const String&
domain, bool isDomainIPAddress, bool findOnly);

This would be better to just use candidateCookie. And I think passing by const
& is preferred then to *.

> Source/WebCore/platform/blackberry/ParsedCookie.h:66
> +    void setDomain(const String& domain, bool domainIsIPAddress = false) {
m_domain = domain.lower(); m_domainIsIPAddress= domainIsIPAddress; }

Please add a space character before =.