[webkit-reviews] review granted: [Bug 95451] Share inline style between cloned Nodes (copy on write.) : [Attachment 161456] Pätch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted Andreas Kling <kling at webkit.org>'s
request for review:
Bug 95451: Share inline style between cloned Nodes (copy on write.)
https://bugs.webkit.org/show_bug.cgi?id=95451

Attachment 161456: Pätch
https://bugs.webkit.org/attachment.cgi?id=161456&action=review

------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
View in context: https://bugs.webkit.org/attachment.cgi?id=161456&action=review


r=me

> Source/WebCore/css/StylePropertySet.cpp:69
> +PassRefPtr<StylePropertySet> StylePropertySet::makeImmutable() const
> +{
> +    if (!isMutable())
> +	   return const_cast<StylePropertySet*>(this);
> +    return createImmutable(m_mutablePropertyVector->data(),
m_mutablePropertyVector->size(), cssParserMode());
> +}

Name does not really describe this function well. I don't have great ideas
though, maybe copyIfNeeded() or similar?