[webkit-reviews] review denied: [Bug 95352] Web Inspector: Create JavaScriptSources based on network resources. : [Attachment 161252] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Vsevolod Vlasov
<vsevik at chromium.org>'s request for review:
Bug 95352: Web Inspector: Create JavaScriptSources based on network resources.
https://bugs.webkit.org/show_bug.cgi?id=95352

Attachment 161252: Patch
https://bugs.webkit.org/attachment.cgi?id=161252&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=161252&action=review


> Source/WebCore/inspector/front-end/NetworkUISourceCodeProvider.js:78
> +	      
resource.request.addEventListener(WebInspector.NetworkRequest.Events.FinishedLo
ading, resourceFinished, this);

We should only add resources that are finished at the first place.

> Source/WebCore/inspector/front-end/NetworkUISourceCodeProvider.js:96
> +	   if ((isDocument &&
this._uiSourceCodeForDocumentResource[resource.url]) || (!isDocument &&
this._uiSourceCodeForScriptResource[resource.url]))

Why do you distinguish those?

> Source/WebCore/inspector/front-end/RawSourceCode.js:38
> +WebInspector.RawSourceCode = function(script)

I don't see why we need this class now.

> Source/WebCore/inspector/front-end/UISourceCode.js:545
> +    setSourceMapping: function(sourceMapping)

You should remove sourceMapping from the constructor now.