[webkit-reviews] review denied: [Bug 95406] Deploy ASCIILiteral in FontCacheWin.cpp : [Attachment 161365] Patch

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has denied  review:
Bug 95406: Deploy ASCIILiteral in FontCacheWin.cpp
https://bugs.webkit.org/show_bug.cgi?id=95406

Attachment 161365: Patch
https://bugs.webkit.org/attachment.cgi?id=161365&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=161365&action=review


> Source/WebCore/platform/graphics/win/FontCacheWin.cpp:330
> +	   AtomicString(ASCIILiteral("Times New Roman")),
> +	   AtomicString(ASCIILiteral("Microsoft Sans Serif")),
> +	   AtomicString(ASCIILiteral("Tahoma")),
> +	   AtomicString(ASCIILiteral("Lucida Sans Unicode")),
> +	   AtomicString(ASCIILiteral("Arial"))

AtomicString should always use AtomicString::ConstructFromLiteral. (I should
prevent AtomicString(ASCIILiteral) explicitly in AtomicString.h.)

The reason is I want to have compile time computation of the hash value in the
future. When that template is done, we would not need to do any access to the
characters at construction.

Sorry, I did not made that clear in my previous explanation, I did not
anticipate this fast mass deployment of literal strings.