[webkit-reviews] review requested: [Bug 95397] Need to merge didFirstVisuallyNonEmptyLayout and didNewFirstVisuallyNonEmptyLayout : [Attachment 161368] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 29 17:31:57 PDT 2012


Beth Dakin <bdakin at apple.com> has asked  for review:
Bug 95397: Need to merge didFirstVisuallyNonEmptyLayout and
didNewFirstVisuallyNonEmptyLayout
https://bugs.webkit.org/show_bug.cgi?id=95397

Attachment 161368: Patch
https://bugs.webkit.org/attachment.cgi?id=161368&action=review

------- Additional Comments from Beth Dakin <bdakin at apple.com>
The API that I added has a sort of silly name: didUnlockLayoutAchievement. I do
have some less-silly ideas for alternatives, such as:

didReachLayoutMilestone
didCompleteLayoutPhase
didAchieveLayoutState

I thought we could have a discussion now during review about the best name.

I plan to remove the old API in a follow-up patch.


More information about the webkit-reviews mailing list