[webkit-reviews] review granted: [Bug 95393] [chromium] setNeedsAnimate should not cause commitRequested to become true : [Attachment 161341] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 29 15:56:45 PDT 2012


James Robinson <jamesr at chromium.org> has granted Nat Duca
<nduca at chromium.org>'s request for review:
Bug 95393: [chromium] setNeedsAnimate should not cause commitRequested to
become true
https://bugs.webkit.org/show_bug.cgi?id=95393

Attachment 161341: Patch
https://bugs.webkit.org/attachment.cgi?id=161341&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=161341&action=review


Cool

> Source/WebKit/chromium/ChangeLog:12
> +	   (WTF):
> +	   (CCLayerTreeHostTestSetNeedsAnimateShouldNotSetCommitRequested):
> +	  
(WTF::CCLayerTreeHostTestSetNeedsAnimateShouldNotSetCommitRequested::CCLayerTre
eHostTestSetNeedsAnimateShouldNotSetCommitRequested):
> +	   (WTF::TEST_F):

can you kill the WTF::? i'd fix prepare-ChangeLog to not do this but it's perl
:\


More information about the webkit-reviews mailing list