[webkit-reviews] review denied: [Bug 95094] [Chromium] Remove contentsScale from GraphicsLayerChromium and WebContentLayer : [Attachment 161337] Piping appliesPageScale to LayerChromium from GraphicsLayer.

[bugzilla-daemon at webkit.org]

Jeff Timanus <twiz at chromium.org> has denied  review:
Bug 95094: [Chromium] Remove contentsScale from GraphicsLayerChromium and
WebContentLayer
https://bugs.webkit.org/show_bug.cgi?id=95094

Attachment 161337: Piping appliesPageScale to LayerChromium from GraphicsLayer.
https://bugs.webkit.org/attachment.cgi?id=161337&action=review

------- Additional Comments from Jeff Timanus <twiz at chromium.org>
This patch implements the basic idea of how we can move the contentsScale code
from GraphicsLayer{Chromium} to LayerChromium.

Essentially this change removes the assignment of contents scale at the
GraphicsLayer level, and instead performs it during
CCLayerTreeHost::updateLayers.

The GraphicsLayer::appliesPageScale property is pushed to the LayerChromium
owned by the GraphicsLayer, and used to control the page scale semantics at the
LayerChromium level.

There are a few issues I wonder about with this change:
 - I'm currently assigning the page scale to all LayerChromium instances in the
tree, where as the old path only assigned the scale to the layer associated
with the path.	I had been hoping that the appliesPageScale selective
application of the contentsScale would filter out layers that should not be
scaled.
 - There are several layout tests that fail with a result of this patch. 
(Attachment forthcoming.)

Is this approach at all sane?  I feel that the complexity of all the different
zoom/scale factors is an indication that this is not the right direction.