[webkit-reviews] review granted: [Bug 93477] 1.9.90 drops symbols, breaking compatibility : [Attachment 161309] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Aug 29 14:07:26 PDT 2012
Martin Robinson <mrobinson at webkit.org> has granted Xan Lopez
<xan.lopez at gmail.com>'s request for review:
Bug 93477: 1.9.90 drops symbols, breaking compatibility
https://bugs.webkit.org/show_bug.cgi?id=93477
Attachment 161309: Patch
https://bugs.webkit.org/attachment.cgi?id=161309&action=review
------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=161309&action=review
> Source/WebCore/bindings/gobject/WebKitDOMCustom.cpp:76
> +WebKitDOMDOMTokenList*
> +webkit_dom_html_element_get_class_list(WebKitDOMHTMLElement* element)
> +{
> + return webkit_dom_element_get_class_list(WEBKIT_DOM_ELEMENT(element));
> +}
You should probably follow WebKit style conventions here and keep the method
signature on one line.
More information about the webkit-reviews
mailing list