[webkit-reviews] review requested: [Bug 84137] [GTK] Properly expose <legend> elements to ATs : [Attachment 161212] proposed patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Aug 29 13:51:11 PDT 2012
Joanmarie Diggs <jdiggs at igalia.com> has asked for review:
Bug 84137: [GTK] Properly expose <legend> elements to ATs
https://bugs.webkit.org/show_bug.cgi?id=84137
Attachment 161212: proposed patch
https://bugs.webkit.org/attachment.cgi?id=161212&action=review
------- Additional Comments from Joanmarie Diggs <jdiggs at igalia.com>
Funny story:
* This patch obsoletes the previous patch.
* The previous patch became obsolete because
it would not apply cleanly given this
morning's committed fix for bug 95248.
(http://trac.webkit.org/changeset/126972)
* I happily created a new post-bug 95248
version tossed at at EWS, everything is
green BUT cr-linux because the fix for bug
95248 was rolled out in bug 95349 hours later.
(http://trac.webkit.org/changeset/127006)
Yes I know these things happen. No big deal. :)
But I would appreciate a review of this or the previous patch even though it
does not currently pass EWS for the reasons described above. Unless Dominic
makes some extreme change to fix bug 95349, one of these patches is bound to
apply cleanly. ;)
Sorry and thanks!
More information about the webkit-reviews
mailing list