[webkit-reviews] review granted: [Bug 95274] REGRESSION: Not sending NPP_SetWindow is causing Flash to not throttle itself : [Attachment 161289] Patch with test

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted Brady Eidson <beidson at apple.com>'s
request for review:
Bug 95274: REGRESSION: Not sending NPP_SetWindow is causing Flash to not
throttle itself
https://bugs.webkit.org/show_bug.cgi?id=95274

Attachment 161289: Patch with test
https://bugs.webkit.org/attachment.cgi?id=161289&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=161289&action=review


> LayoutTests/platform/mac-wk2/plugins/npp-setwindow-called-on-scroll.html:41
> +	if (msg == windowWasSetExpectedResults[windowWasSetCount])
> +		testPassed("NPP_SetWindow called with expected parameters");
> +	else
> +		testFailed("NPP_SetWindow called with: " + msg + " but we
expected " + windowWasSetExpectedResults[windowWasSetCount] + "... Maybe bug
95362 has been fixed?");
> +
> +	++windowWasSetCount;	
> +	if (windowWasSetCommands[windowWasSetCount])
> +		eval(windowWasSetCommands[windowWasSetCount]);
> +}

Tabs?

> LayoutTests/platform/mac-wk2/plugins/npp-setwindow-called-on-scroll.html:46
> +	if (window.testRunner)
> +		testRunner.notifyDone();

More tabs?

> Tools/DumpRenderTree/TestNetscapePlugIn/Tests/LogNPPSetWindow.cpp:2
> + * Copyright (C) 2011 Apple Inc. All rights reserved.

It's 2012 buddy.