[webkit-reviews] review denied: [Bug 95187] Web Inspector: Add ability to replay XHR in network panel. : [Attachment 161256] Patch

[bugzilla-daemon at webkit.org]

Vsevolod Vlasov <vsevik at chromium.org> has denied Pavel Chadnov
<chadnov at google.com>'s request for review:
Bug 95187: Web Inspector: Add ability to replay XHR in network panel.
https://bugs.webkit.org/show_bug.cgi?id=95187

Attachment 161256: Patch
https://bugs.webkit.org/attachment.cgi?id=161256&action=review

------- Additional Comments from Vsevolod Vlasov <vsevik at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=161256&action=review


> Source/WebCore/inspector/InspectorResourceAgent.cpp:595
> +void InspectorResourceAgent::replayXHR(ErrorString* errorString, const
String& requestId)

Add ASSERT_UNUSED(errorString); below to make mac bot happy.

> Source/WebCore/inspector/InspectorResourceAgent.cpp:602
> +    RefPtr<XHRReplayData> XHRData =
m_resourcesData->XHRData(actualRequestId);

xhrData

> Source/WebCore/inspector/InspectorResourceAgent.cpp:654
> +    , m_XHRData(0)

m_xhrData

> Source/WebCore/inspector/NetworkResourcesData.h:120
> +	   RefPtr<XHRReplayData> m_XHRData;

ditto

> Source/WebCore/inspector/NetworkResourcesData.h:153
> +    PassRefPtr<XHRReplayData> XHRData(const String& requestId);

ditto

> Source/WebCore/loader/DocumentThreadableLoader.cpp:386
> +	       InspectorInstrumentation::preflightRequestSucceded(m_document,
m_preflightRequestIdentifier);

No brackets for one line conditionals.