[webkit-reviews] review granted: [Bug 95363] [Chromium] Remove getRenderStyleForStrike from PlatformSupport : [Attachment 161278] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 29 12:30:45 PDT 2012


Adam Barth <abarth at webkit.org> has granted Mark Pilgrim (Google)
<pilgrim at chromium.org>'s request for review:
Bug 95363: [Chromium] Remove getRenderStyleForStrike from PlatformSupport
https://bugs.webkit.org/show_bug.cgi?id=95363

Attachment 161278: Patch
https://bugs.webkit.org/attachment.cgi?id=161278&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=161278&action=review


> Source/WebCore/platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.cpp:321
> -    PlatformSupport::getRenderStyleForStrike(m_family.data(),
(((int)m_textSize) << 2) | (m_typeface->style() & 3), &m_style);
> +    getRenderStyleForStrike(m_family.data(), (((int)m_textSize) << 2) |
(m_typeface->style() & 3), &m_style);

Now that this is a member function, we don't need to pass m_style as an
argument.  We can just access it from inside the function.


More information about the webkit-reviews mailing list