[webkit-reviews] review requested: [Bug 94858] AX: Regression (r126369) - toggle buttons no longer return accessible titles : [Attachment 161275] Fixes the bug

[bugzilla-daemon at webkit.org]

Alejandro Piñeiro <apinheiro at igalia.com> has asked  for review:
Bug 94858: AX: Regression (r126369) - toggle buttons no longer return
accessible titles
https://bugs.webkit.org/show_bug.cgi?id=94858

Attachment 161275: Fixes the bug
https://bugs.webkit.org/attachment.cgi?id=161275&action=review

------- Additional Comments from Alejandro Piñeiro <apinheiro at igalia.com>
This patch fixes the bug using suggestions on the previous comments. I
redefined isButton, but I didn't use it in every case. For example on the
example mentioned by Dominic, I just added ToggleButtonRole on the switch, as
using isButton and keeping the switch for the rest of the cases seemed non
really natural. I also reviewed other cases where ButtonRole was used in order
to try to check if ToggleButtonRole should be used.

About the test:
  * It only test the problem related to the title, as it is the only one
described at the bug title. Should I add more tests?
  * This is a gtk test, as I used as reference the previous toggle button test,
so I include a shouldBe (role), and this is platform specific. Is this a
problem? Should be more platform independent?