[webkit-reviews] review granted: [Bug 94395] [Chrome] Create a toggle button for closed captions : [Attachment 161088] fix typo

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Anna Cavender
<annacc at chromium.org>'s request for review:
Bug 94395: [Chrome] Create a toggle button for closed captions
https://bugs.webkit.org/show_bug.cgi?id=94395

Attachment 161088: fix typo
https://bugs.webkit.org/attachment.cgi?id=161088&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=161088&action=review


> LayoutTests/media/video-controls-captions.html:83
> +	   function trackLoaded()
> +	   {
> +	       checkCaptionsDisplay();
> +
> +	       consoleWrite("");
> +	       consoleWrite("** Captions should not be visible after button is
clicked again **");
> +	       clickCCButton();
> +	       checkCaptionsDisplay();
> +
> +	       endTest();
> +	   }
> +
> +	   function loaded()
> +	   {
> +	       findMediaElement();
> +	       consoleWrite("Set the user language preference so that the track
will be chosen when the CC button is clicked.");
> +	       run("internals.setUserPreferredLanguages(['en'])");
> +
> +	       waitForEvent('canplaythrough', startTest);
> +
> +	       video.src = findMediaFile('video', 'content/counting');
> +	   }

Are you certain that body.load will fire before track.load? If not, this test
will be flakey.