[webkit-reviews] review denied: [Bug 95149] Add the duration attribute to MediaSource : [Attachment 160845] Patch

[bugzilla-daemon at webkit.org]

Dimitri Glazkov (Google) <dglazkov at chromium.org> has denied Victoria Kirst
<vrk at chromium.org>'s request for review:
Bug 95149: Add the duration attribute to MediaSource
https://bugs.webkit.org/show_bug.cgi?id=95149

Attachment 160845: Patch
https://bugs.webkit.org/attachment.cgi?id=160845&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=160845&action=review


> Source/WebCore/Modules/mediasource/MediaSource.cpp:73
> +    if (m_readyState == closedKeyword())
> +	   return std::numeric_limits<float>::quiet_NaN();
> +
> +    return m_player->duration();

This can be just a ternary if.

> Source/WebCore/Modules/mediasource/MediaSource.idl:47
> +	   attribute double duration
> +	       setter raises (DOMException);

Why u break line?

> Source/WebCore/html/HTMLMediaElement.cpp:3260
> +    if (now > dur)

dur->duration.

> LayoutTests/http/tests/media/media-source/media-source.js:325
> +    if (!this.floatingPointEquals_(expected, videoTag.duration))
> +    {

Move brace to same line

> LayoutTests/http/tests/media/media-source/media-source.js:329
> +    {

Ditto.

> LayoutTests/http/tests/media/media-source/media-source.js:337
> +    {

Ditto.

> LayoutTests/http/tests/media/media-source/media-source.js:342
> +    {

Ditto.

> LayoutTests/http/tests/media/media-source/media-source.js:349
> +	   {

Ditto.

>
LayoutTests/http/tests/media/media-source/video-media-source-duration-changed.h
tml:127
> +		   {

Ditto.