[webkit-reviews] review denied: [Bug 95244] ExecutableAllocator should be destructed after Heap : [Attachment 161238] fix the build error
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Aug 29 10:07:23 PDT 2012
Geoffrey Garen <ggaren at apple.com> has denied Yong Li <yoli at rim.com>'s request
for review:
Bug 95244: ExecutableAllocator should be destructed after Heap
https://bugs.webkit.org/show_bug.cgi?id=95244
Attachment 161238: fix the build error
https://bugs.webkit.org/attachment.cgi?id=161238&action=review
------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=161238&action=review
Did you check to make sure the Executable Allocator doesn't use the heap in its
constructor?
> Source/JavaScriptCore/runtime/JSGlobalData.cpp:124
> + , heap(this, heapType)
No need for this initializer inside the #if.
More information about the webkit-reviews
mailing list