[webkit-reviews] review granted: [Bug 95100] [WK2] Add SPI to retrieve internal IDs for web notifications : [Attachment 161154] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Jon Lee <jonlee at apple.com>'s
request for review:
Bug 95100: [WK2] Add SPI to retrieve internal IDs for web notifications
https://bugs.webkit.org/show_bug.cgi?id=95100

Attachment 161154: Patch
https://bugs.webkit.org/attachment.cgi?id=161154&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=161154&action=review


> Source/WebKit2/WebProcess/Notifications/WebNotificationManager.cpp:115
> +uint64_t
WebNotificationManager::notificationIDForTesting(WebCore::Notification*
notification)

No need for WebCore prefix - there is a using directive in this file.

> Source/WebKit2/WebProcess/Notifications/WebNotificationManager.h:75
>      // For testing purposes only.
>      void removeAllPermissionsForTesting();
> +    uint64_t notificationIDForTesting(WebCore::Notification*);

The comment looks redundant.