[webkit-reviews] review granted: [Bug 95119] [chromium] Add WebSettings support for flag to enable/disable gesture tap highlights. : [Attachment 160790] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 29 09:41:32 PDT 2012


Adam Barth <abarth at webkit.org> has granted W. James MacLean
<wjmaclean at chromium.org>'s request for review:
Bug 95119: [chromium] Add WebSettings support for flag to enable/disable
gesture tap highlights.
https://bugs.webkit.org/show_bug.cgi?id=95119

Attachment 160790: Patch
https://bugs.webkit.org/attachment.cgi?id=160790&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=160790&action=review


> Source/WebKit/chromium/src/WebViewImpl.cpp:735
>  #if OS(LINUX)

Why OS(LINUX)?	Presumably this is something we'll want on other OS, like
Android.  Perhaps this should be an ENABLE (or just compiled in all the time).


More information about the webkit-reviews mailing list