[webkit-reviews] review granted: [Bug 95345] Web Inspector: Extract StylesSourceMapping from StylesUISourceCodeProvider. : [Attachment 161230] Patch

[bugzilla-daemon at webkit.org]

Alexander Pavlov (apavlov) <apavlov at chromium.org> has granted Vsevolod Vlasov
<vsevik at chromium.org>'s request for review:
Bug 95345: Web Inspector: Extract StylesSourceMapping from
StylesUISourceCodeProvider.
https://bugs.webkit.org/show_bug.cgi?id=95345

Attachment 161230: Patch
https://bugs.webkit.org/attachment.cgi?id=161230&action=review

------- Additional Comments from Alexander Pavlov (apavlov)
<apavlov at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=161230&action=review


One nit to be fixed before landing.

> Source/WebCore/inspector/front-end/StylesUISourceCodeProvider.js:75
> +	   setTimeout(this._populate.bind(this), 0);

Please FIXME-comment this change, stating that this should be handled in a
different manner (like a DidWorkspaceReset event or something)