[webkit-reviews] review canceled: [Bug 84137] [GTK] Properly expose <legend> elements to ATs : [Attachment 161155] proposed patch

[bugzilla-daemon at webkit.org]

Joanmarie Diggs <jdiggs at igalia.com> has canceled Joanmarie Diggs
<jdiggs at igalia.com>'s request for review:
Bug 84137: [GTK] Properly expose <legend> elements to ATs
https://bugs.webkit.org/show_bug.cgi?id=84137

Attachment 161155: proposed patch
https://bugs.webkit.org/attachment.cgi?id=161155&action=review

------- Additional Comments from Joanmarie Diggs <jdiggs at igalia.com>
(In reply to comment #8)
> (In reply to comment #7)
> > (In reply to comment #6)
> > > (From update of attachment 161155 [details] [details] [details])
> > > I think we probably want to move this legend test to the mac platform
only, because what it is testing is that the titleUIElement is properly set,
not that the tree hierarchy matches something. 

Now the test prints the hierarchy and identifies the titleUIElement within the
hierarchy.

So mac results look like:

  AXRole: AXWebArea AXValue: 
      AXRole: AXGroup AXValue: 
	  AXRole: AXGroup AXValue:	<< fieldset's titleUIElement
	      AXRole: AXStaticText AXValue: Choose a shipping method:
	  AXRole: AXGroup AXValue: 
	      AXRole: AXRadioButton AXValue: 0
	      AXRole: AXStaticText AXValue: Overnight
      AXRole: AXGroup AXValue: 
	  AXRole: AXStaticText AXValue: End of test

And gtk results look like:

  AXRole: document frame 
      AXRole: panel 
	  AXRole: label AXValue: Choose a shipping method:     << fieldset's
titleUIElement
	  AXRole: panel 
	      AXRole: radio button AXValue: 
      AXRole: section AXValue: End of test

Two completely different hierarchies, same titleUIElement, one single
cross-platform layout test. :) Whatdya think?

If you don't like it, I'll go with your original suggestion namely:

> > > so let's move legend.html to mac only and rename to
legend-title-element.html and use this new one in all platforms as something
like legend-hierarchy.html

Thanks again!