[webkit-reviews] review granted: [Bug 95304] Improve string efficiency using StringBuilder and StringOperations : [Attachment 161156] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 95304: Improve string efficiency using StringBuilder and StringOperations
https://bugs.webkit.org/show_bug.cgi?id=95304

Attachment 161156: Patch
https://bugs.webkit.org/attachment.cgi?id=161156&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=161156&action=review


Looks reasonable.  AppleConvertedSpace is confusing.

> Source/WebCore/css/CSSLineBoxContainValue.cpp:60
> +	       text.append(' ');

We should rename .append(UChar) to .appendUChar() or similar so that my brain
can think simple thoughts like "append is slow".... here it's obviously not. :)