[webkit-reviews] review granted: [Bug 95279] [Forms] Make HTMLInputElement::blur()/focus() override-able by input type : [Attachment 161127] Patch 3

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 28 23:04:00 PDT 2012


Hajime Morrita <morrita at google.com> has granted yosin at chromium.org's request
for review:
Bug 95279: [Forms] Make HTMLInputElement::blur()/focus() override-able by input
type
https://bugs.webkit.org/show_bug.cgi?id=95279

Attachment 161127: Patch 3
https://bugs.webkit.org/attachment.cgi?id=161127&action=review

------- Additional Comments from Hajime Morrita <morrita at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=161127&action=review


> Source/WebCore/ChangeLog:9
> +	   override-able by InputType class if
ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS

I don't think we need to hide these code blocks under
ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS.
Overriding method conditionally can cause tricky problem.


More information about the webkit-reviews mailing list