[webkit-reviews] review granted: [Bug 95276] HTMLTokenizer should use the latest EfficientStrings hotness : [Attachment 161112] Patch

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has granted Adam Barth
<abarth at webkit.org>'s request for review:
Bug 95276: HTMLTokenizer should use the latest EfficientStrings hotness
https://bugs.webkit.org/show_bug.cgi?id=95276

Attachment 161112: Patch
https://bugs.webkit.org/attachment.cgi?id=161112&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
Great!

Looking at the implementation of lookAhead(), I think it would be possible to
make a version that does not need static or allocations. I don't know if it is
worth it or not, it depends on how hot this path is.

> Source/WebCore/ChangeLog:9
> +	   Using ASCIILiteral avoids memcpying the string into the heap and
> +	   therefore uses less total memory.

It does not always saves memory (due to the way the allocator works) but it is
also always faster ;)