[webkit-reviews] review granted: [Bug 71401] [CSS Shaders] Use CSS transform parsing code within CSS Shader : [Attachment 161092] Patch V3

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Chiculita Alexandru
<achicu at adobe.com>'s request for review:
Bug 71401: [CSS Shaders] Use CSS transform parsing code within CSS Shader
https://bugs.webkit.org/show_bug.cgi?id=71401

Attachment 161092: Patch V3
https://bugs.webkit.org/attachment.cgi?id=161092&action=review

------- Additional Comments from Dean Jackson <dino at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=161092&action=review


> Source/WebCore/css/StyleResolver.cpp:5297
> +	   return parseCustomFilterNumberParamter(name, values);

Seems we missed the typo in the name of this method. We might as well fix it
now.

> Source/WebCore/css/StyleResolver.h:267
>      PassRefPtr<CustomFilterParameter> parseCustomFilterNumberParamter(const
String& name, CSSValueList*);

See above - typo here and since we're fixing above and below it...

> Source/WebCore/platform/graphics/filters/FECustomFilter.cpp:277
> +	   // The viewport is a box with the size of 1 unit, so we are scalling
up here to make sure that translations happen using real pixels

typo pixel not pixels