[webkit-reviews] review granted: [Bug 95260] Handle sticky that overflows its container : [Attachment 161085] Patch

[bugzilla-daemon at webkit.org]

Ojan Vafai <ojan at chromium.org> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 95260: Handle sticky that overflows its container
https://bugs.webkit.org/show_bug.cgi?id=95260

Attachment 161085: Patch
https://bugs.webkit.org/attachment.cgi?id=161085&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=161085&action=review


Seems reasonable. It's hard to evaluate whether this really makes sense since I
can't think of use-cases, but this is clearly an improvement IMO.

> LayoutTests/fast/css/sticky/sticky-overflowing.html:8
> +	   height: 2000px;

It's annoying, but our reftesting infrastructure still only does 800x600 pixel
dumps, so anything below the 600th pixel won't actually get tested. We should
probably fix this eventually, but I think it requires lots of plubming (e.g.
modifying each DRT to be able to dump the whole image).

> LayoutTests/fast/css/sticky/sticky-overflowing.html:68
> +	   A<br>
> +	   A<br>
> +	   A<br>
> +	   A<br>
> +	   A<br>
> +	   A<br>
> +	   A<br>
> +	   A<br>
> +	   A<br>
> +	   A<br>
> +	   A<br>
> +	   A<br>
> +	   A<br>

This is fine, but you could also just use a single div with a fixed
height/width.