[webkit-reviews] review granted: [Bug 95257] [chromium] Remove HUD layer when rootLayer is set to null : [Attachment 161082] Patch

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has granted Dana Jansens
<danakj at chromium.org>'s request for review:
Bug 95257: [chromium] Remove HUD layer when rootLayer is set to null
https://bugs.webkit.org/show_bug.cgi?id=95257

Attachment 161082: Patch
https://bugs.webkit.org/attachment.cgi?id=161082&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=161082&action=review


> Source/WebKit/chromium/ChangeLog:10
> +	   (WTF):

can you remove these WTF's from the ChangeLog? the changelog generator script
is stupid about anonymous namespaces

> Source/WebKit/chromium/tests/CCHeadsUpDisplayTest.cpp:36
> +using namespace WebCore;
> +using namespace WebKit;
> +using namespace WebKitTests;
> +using namespace WTF;

this is a bit excessive - can you trim it down so we know what we're actually
depending on? i'm pretty sure you don't need using namespace WTF ever - if you
#include the appropriate <wtf/...> header it puts the relevant things (like
OwnPtr) in the global namespace for you

> Source/WebKit/chromium/tests/CCThreadedTest.h:34
> +#include <public/WebThread.h>

this isn't used, is it? kill if not