[webkit-reviews] review granted: [Bug 94727] Content detection should not disrupt the page behaviour : [Attachment 161026] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Leandro Graciá Gil
<leandrogracia at chromium.org>'s request for review:
Bug 94727: Content detection should not disrupt the page behaviour
https://bugs.webkit.org/show_bug.cgi?id=94727

Attachment 161026: Patch
https://bugs.webkit.org/attachment.cgi?id=161026&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=161026&action=review


Thanks for iterating on the patch!

> Source/WebKit/chromium/src/WebViewImpl.cpp:4009
> +	   if (node->isLink() || (touchType != WebInputEvent::GestureLongPress
> +		   && (node->willRespondToTouchEvents() ||
node->willRespondToMouseClickEvents()))) {
> +	       return false;

I would have broken this up in to a couple of if-statements to make it easier
to understand the logic here, but this is fine too.