[webkit-reviews] review granted: [Bug 95040] [chromium] Add CompositorSupport interface for constructing compositor classes : [Attachment 160861] Patch

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has granted James Robinson
<jamesr at chromium.org>'s request for review:
Bug 95040: [chromium] Add CompositorSupport interface for constructing
compositor classes
https://bugs.webkit.org/show_bug.cgi?id=95040

Attachment 160861: Patch
https://bugs.webkit.org/attachment.cgi?id=160861&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=160861&action=review


> Source/Platform/chromium/public/WebPassOwnPtr.h:35
> +#include "base/memory/scoped_ptr.h"

This adds a new circular dependency between WebKit and Chromium, but it is
probably fairly unlikely that this path will ever change.

> Source/Platform/chromium/public/WebPassOwnPtr.h:52
> +//	OwnPtr<Foo> foo = ...->createFoo();

It would be good to complete this by showing how to implement on the WebKit
side and call on the Chromium side.