[webkit-reviews] review denied: [Bug 95129] [chromium] Link highlight should clear on page navigation. : [Attachment 160959] Patch

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has denied W. James MacLean
<wjmaclean at chromium.org>'s request for review:
Bug 95129: [chromium] Link highlight should clear on page navigation.
https://bugs.webkit.org/show_bug.cgi?id=95129

Attachment 160959: Patch
https://bugs.webkit.org/attachment.cgi?id=160959&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=160959&action=review


I think your test is still flaky. Otherwise, this looks good.

>
LayoutTests/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-s
imple-navigate.html:31
> +	   window.setTimeout(function() { window.testRunner.notifyDone(); },
0);

This seems wrong - if the navigation failed or didn't finish in time, we don't
want to end the test. Are you hitting situations where runTest() isn't running
at all on -destination? Can you figure out why not?

>
LayoutTests/platform/chromium-linux/compositing/gestures/resources/gesture-tapH
ighlight-simple-navigate-destination.html:15
> +	   window.testRunner.notifyDone();

This is the only thing that should be ending the test