[webkit-reviews] review requested: [Bug 94810] Vector::shrinkToFit should use realloc when canCopyWithMemcpy is true : [Attachment 161042] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Aug 28 12:52:55 PDT 2012
Yong Li <yoli at rim.com> has asked for review:
Bug 94810: Vector::shrinkToFit should use realloc when canCopyWithMemcpy is
true
https://bugs.webkit.org/show_bug.cgi?id=94810
Attachment 161042: Patch
https://bugs.webkit.org/attachment.cgi?id=161042&action=review
------- Additional Comments from Yong Li <yoli at rim.com>
Sorry for keeping changing it... Actually we don't want the 1K threshold. 1)
the measurement for small blocks is not stable. It is actually very close as
realloc() doesn't nothing but malloc/memcpy/free. 2) if realloc() was slower,
it should be fixed and improved anyway.
More information about the webkit-reviews
mailing list