[webkit-reviews] review granted: [Bug 93723] [NRWT] The nrwt should check the contents of the skipped files with --lint-test-files : [Attachment 160986] proposed fix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 28 12:35:07 PDT 2012


Dirk Pranke <dpranke at chromium.org> has granted Kristóf Kosztyó
<kkristof at inf.u-szeged.hu>'s request for review:
Bug 93723: [NRWT] The nrwt should check the contents of the skipped files with
--lint-test-files
https://bugs.webkit.org/show_bug.cgi?id=93723

Attachment 160986: proposed fix
https://bugs.webkit.org/attachment.cgi?id=160986&action=review

------- Additional Comments from Dirk Pranke <dpranke at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=160986&action=review


> Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py:96
> +	       _log.warning('The following test %s from the Skipped list
doesn\'t exists!' % test_name)

Nit: "exist", not "exists", and I wouldn't use an exclamation point.


More information about the webkit-reviews mailing list