[webkit-reviews] review granted: [Bug 94822] OPENTYPE_VERTICAL support for Chromium Win : [Attachment 160980] Updated ChangeLog and Font::drawGlyphs in FontChromiumWin.cpp

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has granted Koji Ishii <kojiishi at gmail.com>'s
request for review:
Bug 94822: OPENTYPE_VERTICAL support for Chromium Win
https://bugs.webkit.org/show_bug.cgi?id=94822

Attachment 160980: Updated ChangeLog and Font::drawGlyphs in
FontChromiumWin.cpp
https://bugs.webkit.org/attachment.cgi?id=160980&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=160980&action=review


When I mark something as a nit, I mean you can commit with or without the
change (it's more like a suggestion than a requirement).  If it's something
small, then you don't need to ask for review again, although if you want me to,
I don't mind reviewing again.

In this patch, since I'm setting cq+, you could make a follow up change to
address the nit, but it's not a big deal either way.

> Source/WebCore/platform/graphics/chromium/FontChromiumWin.cpp:401
> +    const OpenTypeVerticalData* verticalData = font->verticalData();
> +    if (verticalData) {
> +	   Vector<FloatPoint, kMaxBufferLength> translations;
> +	   Vector<GOFFSET, kMaxBufferLength> offsets;

Nit: I would probably move all this code into a helper function, but this is OK
too.