[webkit-reviews] review denied: [Bug 95169] [ShadowDOM] Shadow elements in the input element should be focusable. : [Attachment 160898] Patch 1
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Aug 27 22:28:20 PDT 2012
Kent Tamura <tkent at chromium.org> has denied yosin at chromium.org's request for
review:
Bug 95169: [ShadowDOM] Shadow elements in the input element should be
focusable.
https://bugs.webkit.org/show_bug.cgi?id=95169
Attachment 160898: Patch 1
https://bugs.webkit.org/attachment.cgi?id=160898&action=review
------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=160898&action=review
> Source/WebCore/html/HTMLAudioElement.h:51
> + virtual bool hasCustomFocusLogic() const OVERRIDE;
This should be defined at HTMLMediaElement instead of HTMLAudioElement and
HTMLVideoElement because HTMLMediaElement is responsible to build shadow sub
tree for media control UI.
More information about the webkit-reviews
mailing list